Hi Bin-Li and Kai-Chuan, For questing:
The patch that adds support for the "Macro" is okay, because it is used for direct device enablement for realtek chipsets. However, d/p/lp2130313/0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch is refactoring existing code to use this Macro with no supposed change in functionality or bug fix. It has a large regression risk due to modifying the file "ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf", which affects ALL Intel chipsets, as well as a few other specific chipsets in other files. Now, we decided to accept this because from what we can tell, this was suppose to have landed in -devel during the QQ development cycle, and it exists in noble, oracular, plucky, and now, resolute. It has been in noble onward since May 2025, and is largely well tested by the community now. We searched the bug trackers, and no one really complained about change in behaviour or anything. We did notice the upgrade regression bug 2130874 which this patchset fixes. Ideally this patch should not have been accepted into N/O/P, and it was also missed during SRU review the first time by separate people, so its easy for this to slip through the cracks. But in the future, this is a refactor type commit, and does not directly impact users, so please only include these sorts of fixes if they directly fix or impact users in some way. We have accepted questing. Thanks, Matthew and ROAF. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2129952 Title: Support for Realtek audio solution ALC3329B+ALC1708B on new Dell PTL platform To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/2129952/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
