Brad, I think that sounds like a great idea. Your right, it does need some work, I plan on working on the portlet this weekend so I'm sure I'll be adjusting several things. As for units of measurement I have a boolean variable in Weather.java called metric that could be used to determine units of measurement, however, it may be more desirable to add temperatureUnit and windUnit properties if that's what your referring to?
I am not too familiar with enums, I don't ever really use them. Enums basically map a string name to an integer. Were you thinking of mapping all weather conditions in an enumeration? I'm open to ideas but can you explain more? Humidity should definitely be an Integer or Double, that was a typo on my part. The best place to put the NOAA implementation would be in org.jasig.portlet.dao.noaa and you would implement IWeatherDao. I'm probably also going to need to create an abstract class or interface for validation that will require some implementing based on the service. I plan on doing that this weekend. Dustin On Feb 15, 2008 9:16 AM, Brad Johnson <[EMAIL PROTECTED]> wrote: > Hello Dustin, > > It's always good to have more than one implementation when trying to > make a general interface. :-) As your weather DAO interface becomes more > solid I might port the NOAA XML weather service implementation to your > API. > > I notice you still need to document units on methods in your interfaces > like getTemperature() and getWind() that return a double. > > Also, I wonder if we should have enumerations instead of strings for > things like wind direction and condition. Shouldn't humidity be a > percent? Couldn't it be an integer or a double instead of a string? > > Where would you want the NOAA XML API implementation in your package > structure? Do you want it in org.jasig.portlet.weather.service? > > thanks, > Brad Johnson > > On Thu, 2008-02-14 at 17:28 -0700, Dustin S. icedout3e-at-gmail.com | > JASIG-List-2| wrote: > > The general consensus seems to be in favor of using AccuWeather so I > > would like to proceed with implementation of this service and as I > > hear more from AccuWeather I will update this thread. We can also > > continue another discussion as to the inclusion in uPortal. > > > > On Thu, Feb 14, 2008 at 3:55 PM, Jen Bourey > > <[EMAIL PROTECTED]> wrote: > > Hi Dustin, > > > > At the moment the source is only in our local repository, but > > I'd be more than happy to contribute it. It might make sense > > to reorganize the files to use maven first, which shouldn't > > take long. > > > > - Jen > > > > > > On Thu, Feb 14, 2008 at 5:15 PM, Dustin S. > > <[EMAIL PROTECTED]> wrote: > > > > Jen, > > > > Is the the source of your portlet available anywhere? > > Would you mind committing it to a branch > > in /sandbox/WeatherPortlet ...? I'm sure this could be > > useful for development. > > > > Thanks, > > Dustin. > > > > > > On Thu, Feb 14, 2008 at 9:46 AM, Jen Bourey > > <[EMAIL PROTECTED]> wrote: > > > > > > This looks fantastic! > > > > At Yale we have a Spring PortletMVC weather > > portlet that uses JAXB to unmarshall the Yahoo > > weather service feeds, then displays the data > > in a JSP page. I wanted to use the XML data > > rather that just display the html in the RSS > > feed, since it would give us better control > > over the presentation, as well as the ability > > to display more data. We've been pretty happy > > with that approach so far, but Yahoo doesn't > > provide a good way to get locations for > > international locations, and I know > > AccuWeather has access to even more data. I > > think it would be pretty simple to use a > > similar approach to display the data from the > > AccuWeather service if we wanted. > > > > Screenshots of the current Yale portlet are > > here: > > > http://tp.its.yale.edu/confluence/display/YIP/Weather+Portlet. > > > > - Jen > > > > > > > > On Wed, Feb 13, 2008 at 11:09 PM, Dustin S. > > <[EMAIL PROTECTED]> wrote: > > Jen, > > The data provided is far superior to > > any other service that I've seen, I > > was really impressed when I first saw > > it. The API for getting locations is > > also really nice IMO. You can see an > > example here: > > > http://uport.accu-weather.com/widget/uport/city-find.asp?location=london . > The location string can take many types of values (zipcode, city, city and > country). > > > > > > -- > > > > You are currently subscribed to > > [email protected] as: > > [EMAIL PROTECTED] > > To unsubscribe, change settings or access > > archives, see > > > http://www.ja-sig.org/wiki/display/JSG/uportal-dev > > > > > > -- > > You are currently subscribed to > [email protected] as: [EMAIL PROTECTED] > > > > To unsubscribe, change settings or access archives, > > see > > http://www.ja-sig.org/wiki/display/JSG/uportal-dev > > > > > > -- > > You are currently subscribed to [email protected] as: > [EMAIL PROTECTED] > > > > > > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev > > > > -- > > You are currently subscribed to [email protected] as: > [EMAIL PROTECTED] > > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev > > -- > Join your friends and colleagues at JA-SIG 2008 - "Higher Education > Solutions: The Community Source Way!" > April 27th - 30th, 2008 in St. Paul, Minnesota USA > > Featuring CAS, DSpace, Fedora, Fluid, Internet2, Kuali, Sakai, uPortal, > and more! > Information/Registration at: > http://www.ja-sig.org/conferences/08spring/index.html > > You are currently subscribed to [email protected] as: > [EMAIL PROTECTED] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev > -- Join your friends and colleagues at JA-SIG 2008 - "Higher Education Solutions: The Community Source Way!" April 27th - 30th, 2008 in St. Paul, Minnesota USA Featuring CAS, DSpace, Fedora, Fluid, Internet2, Kuali, Sakai, uPortal, and more! Information/Registration at: http://www.ja-sig.org/conferences/08spring/index.html You are currently subscribed to [email protected] as: [EMAIL PROTECTED] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
