Re: [uportal-dev] LAYOUT_CACHE: Is this an interesting enhancement?

[Eric Dalquist]

Drew Wills wrote:

I've created a JIRA: http://www.ja-sig.org/issues/secure/ManageAttachments.jspa?id=16023

And I've attached an updated patch.

Eric Dalquist wrote:

I think a user can actually have multiple layouts loaded. In the database I believe layouts are keyed via userId (numeric) and profileId (numeric). You might want to look at using a composite of those two values for the cache key to ensure we don't add unneeded restriction to the object model.

You're right about the database, but I don't think that's supported in the code... at least I think a user would need two concurrent sessions, as well as two profiles each having a different layout. But I've made the adjustment: the layoutCache key is now {username}-{layoutId}.

Yeah I'm pretty sure they would need two sessions as well but the profile functionality was meant for doing different layouts for things like browsers versus PDAs so they would have multiple sessions anyways. Glad you could make the change though.

The changing when logged in issue is ok I think, we'll just ship with a default idle expire time of 30 minutes which would match session timeouts.

Default changed to timeToIdleSeconds="1800" (30 min).

This all sounds good. Lets take another look at the cache key and then get this in for 3.1

Not 3.0.2?

I'm ok either way on this point.

As Chris says, this is a pretty significant change in behavior under certain conditions so I would be very wary of including it in a point release.

Thanks for the great work!
-Eric

smime.p7s
Description: S/MIME Cryptographic Signature