Drew Wills wrote:
A few questions about the swap filter now that I've had more time to look at it. -Should the cleanup code at the end of doFilter be in a finally block to ensure things don't leak in case of exceptions? -Is there a chance of a memory leak by tracking some of the swap data via the TRACKING Map? Is there a chance that entries may not get removed from this Map?Eric Dalquist wrote:This looks like a very nice app. Looking at this and the DLM auth filtering I think I'd like to get them into 3.0.2 as these are features we've had a lot of requests for and neither set of changes seems to be problematic for a patch release.Sounds excellent. I'd be happy for it to go down this way.
Yeah I'm thinking for 3.1 we add this as a flow view with permissions check code moved into a helper bean (similar to how the other swapper flows have helper beans). We should be able to re-use the code that actually does the identity swap that was just added to 3.1. The swapper code in 3.1 was added via small modifications to the Login and Logout servlets which watch for a portal session attribute to do the swap and unswap.For 3.1 I'd like to find a little time to chat with you Drew to see about how we can merge this with the other new administrative UIs for the swapper portlets. I'm thinking we could probably make this portlet a slightly modified view into the ID swapper that was just added for 3.1?I'd been thinking something similar, though I'd like to retain the permissions check that happens as someone tries to assume a different identity.
-Eric
drew wills
smime.p7s
Description: S/MIME Cryptographic Signature
