Le 08/05/2017 à 12:16, Taher Alkhateeb a écrit :
inline

On Mon, May 8, 2017 at 12:42 PM, Jacques Le Roux <
[email protected]> wrote:

Le 08/05/2017 à 10:20, Taher Alkhateeb a écrit :

I don't think we need to repeat ourselves. The discussion in this thread
already mentioned names to replace loadDefault

So I understand that loadAllData, which is quite clear, is OK to replace
loadDefault

The only one who proposed loadAllData is you

I'll propose an user vote (more a survey, it's a trivial change) on each 
proposed names


As for shutdown, this is again repeating a discussion that was had a while
ago and shows in detail why it was not _replaced_

Please do you have a reference I can't find nor remember an explanation :/
Maybe few words again would be easier?

"shutdown" is a server command (probably since the beginning of the
project), "stop" was an ant target. We discussed in the ML and JIRA
multiple times that we should reduce the amount of tasks to a minimum and
instead let users control the system directly by issuing server commands.
The server commands are --start --shutdown --load-data --test --portoffset
and --help

I don't have a problem in renaming --shutdown to --stop as a server
command.

That's only what I suggest

Thanks for your explanation

Jacques

The problem is in adding new shortcut tasks in gradle because you
then lose the flexibility of issuing commands to OFBiz. The only shortcut
commands that exist are loadDefault and testIntegration because we have to
run them every time before making a commit "gradlew cleanAll loadDefault
testIntegration". Beyond that, we're just repeating ourselves needlessly
and confusing users. One example where we lose value is in debugging. For
example, take the following variations:

./gradlew "ofbiz --test"
./gradlew "ofbizDebug --test"
./gradlew "ofbiz --shutdown"
./gradlew "ofbizDebug --shutdown"

As you can can see, giving the user flexibility in debugging whatever
command she issues is an advantage. If users, however, are not familiar
with the server commands and they rely on the shortcut commands, then they
lose the above mentioned advantage.


Jacques


On Mon, May 8, 2017 at 10:37 AM, Jacques Le Roux <
[email protected]> wrote:

Hi All,
Would we agree on loadAllData?

I also would like to replace shutdown by stop (we have start, so stop),
agreed?

Jacques



Le 19/04/2017 à 20:49, Jacques Le Roux a écrit :

Maybe loadAllData ?
And what about stop instead of shutdown. Why shutdown replaced stop?

Jacques


Le 19/04/2017 à 10:12, Taher Alkhateeb a écrit :

I would suggest "loadData" to keep it consistent with the actual alias
"--load-data" and in the README.md and task description describe what
that
means.

On Wed, Apr 19, 2017 at 10:57 AM, Jacques Le Roux <
[email protected]> wrote:

+1 for loadAll, clearer indeed

I also got trapped by "shutdown" (for ofbizBackground), instead of
"stop"
we had before.

Would you agree (All) to change it too? Not too late right?

Jacques



Le 19/04/2017 à 09:35, Jacopo Cappellato a écrit :

Hi Craig,

the name loadDefault may be a bit misleading: it actually loads the
seed
data but also testing and demo data (maybe loadAll may be more
accurate).
Anyway, you are probably looking for:

./gradlew "ofbiz --load-data readers=seed,seed-initial"

You will find a description of the various options and their meaning
in
the
README.md file section titled "Data loading tasks".

Regards,

Jacopo

On Wed, Apr 19, 2017 at 2:40 AM, Craig Parker<[email protected]>
wrote:

./gradlew cleanAll loadDefault will load some test data. Or is that
wrong?

I'm only thinking so because I saw things in the PRODUCTS table
besides
the
item I started creating.

Dropping the databases, running and firing OFBiz up again seems to
have
rebuilt the databases (I thought I'd read somewhere that they'd get
rebuilt
like that), but there's no data. This was the desired effect, but I
can't
launch the software now. I can post the whole error, or just say
that
I
see
a lot of "Template location is empty" messages.

Is that the right way to start with a clean slate and I missed a
step, or
is that totally wrong?





Reply via email to