Hi,
quick update: I have slightly improved the name generation for MappingItemTransformer implementations.

Also, I have verified that Admin Console's "Manage Resources" keeps showing non-assigned resources with italic.

Regards.

On 16/07/2018 13:45, Francesco Chicchiriccò wrote:
On 16/07/2018 08:40, Mikael Ekblom wrote:

Hi,

As such, the conversion regarding the database went pretty well. One thing though that I found out for the mapping item transformation classes was, that the name of the transformation actions are not shown within the provision interface with their real names when you are about to assign available mapping item transformers.  Instead, they are shown with an id string like the following: “MappingItemTransformer_1650f483-5ad5-48bf-90f4-835ad528bf0”.  Somehow the “body text” is ignored.


Yes, this is due to lines

https://github.com/apache/syncope/blob/2_1_X/core/upgrade/src/main/java/org/apache/syncope/core/upgrade/GenerateUpgradeSQL.java#L118-L125

and

https://github.com/apache/syncope/blob/2_1_X/core/upgrade/src/main/java/org/apache/syncope/core/upgrade/GenerateUpgradeSQL.java#L421-L428

Feel free to submit a PR if you want to improve this behavior.

As such, this is a valid object identifier, but it is not that helpful…J. Other pull- and push actions are shown correctly.

Another thing I found is, that when you list the resources for a single user through “Manage resources”, the resources themselves are not sorted according to the assigned status as was the case in 2.0.8 for example. The assigned resources are not shown through /italic /as for the un-assigned resources. But the checkboxes are not checked by default and the assigned resources are not shown first in the list.


Such changes came from SYNCOPE-1299 (Manual Reconciliation) which improved the Resource handling, and are available in Syncope 2.0.9 as well. You can click on each row (with resource name) and access features for (i) comparing the entry in Syncope against the object on the external resource, overwriting the entry in Syncope with object on external resource (pull) and overwriting theobject on external resource with entry in Syncope (push).

Anyway, indicating somehow that a resource is assigned (italic for non-assigned resources, as in the past) might be an idea.

Checkboxes are (and have always been) for bulk actions.

Regards.

*From:*Francesco Chicchiriccò [mailto:[email protected]]
*Sent:* torstai 12. heinäkuuta 2018 12.01
*To:* [email protected]
*Subject:* Re: Apache Syncope version 2.1 findings

On 12/07/2018 10:45, Mikael Ekblom wrote:

    Hi,

    Alright, looks good! Another question that I have is for the
    beforeProvision mapping transformation actions and the
    MappingItemTransformer class that is mentioned in the
    documentation: the link from the documentation gives a 404 for
    this item and I cannot find it within the source either? Is it
    supposed to be there?


Thanks for reporting, MappingItemTransformer should have been ItemTransformer, I have updated the documentation accordingly.


    In version 2.1, all my transformation actions based on  the
    ItemTransformer interface are not visible anymore.   Might be an
    issue with the previous upgrade too, so I’ll revert back to the
    latest snapshot and try again from scratch and see.


This is a consequence of SYNCOPE-1335: you might want to use

https://repository.apache.org/content/groups/snapshots/org/apache/syncope/core/syncope-core-upgrade/2.1.1-SNAPSHOT/syncope-core-upgrade-2.1.1-20180712.064139-8.zip

rather than the official syncope-core-upgrade-2.1.0.zip, which contains the fix.

Regards.

    *From:*Francesco Chicchiriccò [mailto:[email protected]]
    *Sent:* torstai 12. heinäkuuta 2018 9.18
    *To:* [email protected] <mailto:[email protected]>
    *Subject:* Re: Apache Syncope version 2.1 findings

    FYI,

    https://cwiki.apache.org/confluence/display/SYNCOPE/Upgrade+from+2.0+Jazz

    is now complete.

    Regards.

    On 11/07/2018 12:21, Francesco Chicchiriccò wrote:

        On 10/07/2018 17:08, Mikael Ekblom wrote:

            Hi,

            I have now tested the 2.1 version or let us say that the
            installation procedure was tested. My installation path
            was from 2.0.9.


        Hi Mikael,
        thanks for this review.
        You can find my replies embedded below.

        I am currently working at a better upgrade page:

        
https://cwiki.apache.org/confluence/display/SYNCOPE/Upgrade+from+2.0+Jazz

        Regards.



            My findings are the following:

             1. I had the same regarding the Junit version error
                message regarding syncope console, but I did not
                delete the junit dependency in the console pom-file.
                I just added the version information as
                 <version>4.8.1</version>  dummy value and it went
                through.


        Yep, SYNCOPE-1334 addresses this issue.
        I will add this to the upgrade page.




             1. The database script generated the required sql-file
                as expected, but I had to manually run most of it to
                double check that i got all the relations and
                indexes set. I noted during this process that the
                table ownership was changed from syncope to the
                default postgres DBA user, so I had to change this
                manually. This was for the new relations that were
                created through the sql scipt file. Easily fixed though.


        I understand, but I think this is expected. It is also the
        reason why we preferred to generate a SQL script rather than
        directly executing the generate upgrade statements.
        BTW, I have found some missing statements (see SYNCOPE-1335),
        that I will also report in the upgrade page.




             1. The core is not so keen on starting...:) The rest is
                up and running (enduser and syncope-console) but not
                the core. The log claims the following:

                 1. 17:31:00.300 ERROR
                    org.flowable.engine.impl.cmd.ValidateV5EntitiesCmd
                    - Found v5 process definitions that are the
                    latest version. Enable the
                    'flowable5CompatibilityEnabled' property in the
                    process engine configuration and make sure the
                    flowable5-compatibility dependency is available
                    on the classpath
                    17:31:00.304 ERROR
                    org.flowable.engine.impl.cmd.ValidateV5EntitiesCmd
                    - Found v5 process definition with id:
                    userWorkflow:61:5012291, and key: userWorkflow


        I will publish the complete procedure to avoid this error in
        the upgrade page.



             1. I hope that I do not have to recreate every user due
                to this error...:)


        No, not needed, of course.



             1. Regarding number 3: can I somehow affect this during
                run time within workflow.properties or must it be
                done within the source and the corresponding xml
                configuration for flowable itself? The flowable
                engine has not been in use here before. I just do not
                find out right now where this configuration change
                should go?

            Otherwise...all my own customization did compile for
            version 2.1 also after some modifications. Optional seems
            to be in pretty heavy use....:) More has been packed into
            interfaces.

        I will also include the expected code modifications, mainly
        due to widespread adoption of Java 8 language features, in
        the upgrade page.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Reply via email to