On 06/13/12 10:56 PM, April Chin wrote:
Hi Edwin,
In components/ksh93/source-demo-ksh93.p5m,
do you need to add
set name=pkg.human-version value=$(IPS_HUMAN_VERSION)
also, as you did with ksh93.p5m?
Tthat seems a good idea, as the source-demo-ksh package is something
we've created for Solaris by splitting it out of the ksh93 build, then
really it should have the same human readable version.
Because you are renaming packages, you need to
create a package (a .p5m file) with the old shell/ksh name,
with a dependency on the new shell/ksh93 package, and
set name=pkg.renamed value=true
Excellent - I was wondering if it was necessary to put some means of
tracing the rename in - thank you :-)
Also, in components/ksh93/ksh93.p5m, you'll need an optional
dependency on the old shell/ksh package.
Ditto for renaming source/demo/ksh package to
source/demo/ksh93.
Will do.
See components/php-5_2/apache-php5.p5m and
components/php-5_2/apache-php52.p5m for an example of a package
rename (from apache-php5 to apache-php52).
The build # listed there (18) is the build into which the rename
came into effect. For you, this would probably be build 19.
Thats extremely useful, thanks!
I talked to Craig Mohrman, who did the apache-php5 rename, and
he said for testing purposes only (do *not* put this change back),
he needed to temporarily tweak the BUILDID listed in
make-rules/ips-buildinfo.mk,
to match the build # he put into the .p5m files. This allowed him to
test installation of his renamed package.
April
I had so far stopped the pkglint dupaction errors screaming, but this
sounds like the correct way to go here: Its a complete solution :-)
On 06/13/12 07:25 AM, Edwin Beasant wrote:
Can I please have a code review for:
7168548 <http://monaco.us.oracle.com/detail.jsf?cr=7168548> package shell/ksh
version number needs to conform.
Webrev:
http://jurassic.us.oracle.com/~ebeasant/webrevs/7168548/
Workspace:
x86: /net/shelf.uk.oracle.com/vol01/builds/ebeasant/userland/7168548
SPARC: /net/grinah.uk.oracle.com/builds/ebeasant/7168548
Cheers,
Edwin Beasant
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
