On 06/14/12 09:59 PM, [email protected] wrote:
Thanks for the help - I've put all the suggestions together and
respun and tested the results. Danek has put his seal of approval on
it too:
http://jurassic.us.oracle.com/~ebeasant/webrevs/7168548/
components/ksh93/developer-astdev.p5m
Why do you have this under components/ksh93 rather than
components/meta-packages/history where all of the other
obsoleted/renamed package manifests live?
I was following the pattern of "components/php-5_2/apache-php5.p5m" and
"components/php-5_2/apache-php52.p5m" for a package rename, and I'm
afraid I didn't know about the
meta-packages directory at the time. (I do now!)
Should the above manifests be moved to there as well, or is there an
exception for the php-5_2 manifests?
The copyright was unnecessarily changed - it should presumedly
keep the year range.
Interesting: what's the copyright situation when the files are
effectively moved/split as they have been in this case? I was regarding
it as fundamentally new content, therefore taking the fresh Copyright
date in this case.
I've put the old date range back for now.
Line 24-25 - Unnecessary continuation, lines can be joined.
Line 28-29 - Unnecessary continuation, lines can be joined.
Done.
components/ksh93/developer-astdev93.p5m
Line 64-65 - Unnecessary continuation, lines can be joined.
Done.
components/ksh93/ksh93.p5m
Line 115-116 - Unnecessary continuation, lines can be joined.
Done.
components/ksh93/shell-ksh.p5m
Why do you have these under components/ksh93 rather than
components/meta-packages/history where all of the other
obsoleted/renamed package manifests live?
<see above>
Line 24-25 - Unnecessary continuation, lines can be joined.
Done.
Line 28-29 - Unnecessary continuation, lines can be joined.
Done.
components/ksh93/source-demo-ksh.p5m
Why do you have these under components/ksh93 rather than
components/meta-packages/history where all of the other
obsoleted/renamed package manifests live?
<see above>
The copyright was unnecessarily changed - it should presumedly
keep the year range.
<see above>
Line 24-25 - Unnecessary continuation, lines can be joined.
Done.
Line 28-29 - Unnecessary continuation, lines can be joined.
Done.
components/ksh93/source-demo-ksh93.p5m
Line 62-63 - Unnecessary continuation, lines can be joined.
Thanks,
Edwin
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
