Thanks for the help - I've put all the suggestions together and respun and tested the results. Danek has put his seal of approval on it too:

http://jurassic.us.oracle.com/~ebeasant/webrevs/7168548/

components/ksh93/developer-astdev.p5m

        Why do you have this under components/ksh93 rather than
        components/meta-packages/history where all of the other
        obsoleted/renamed package manifests live?

        The copyright was unnecessarily changed - it should presumedly
        keep the year range.

        Line 24-25 - Unnecessary continuation, lines can be joined.

        Line 28-29 - Unnecessary continuation, lines can be joined.

components/ksh93/developer-astdev93.p5m

        Line 64-65 - Unnecessary continuation, lines can be joined.

components/ksh93/ksh93.p5m

        Line 115-116 - Unnecessary continuation, lines can be joined.

components/ksh93/shell-ksh.p5m

        Why do you have these under components/ksh93 rather than
        components/meta-packages/history where all of the other
        obsoleted/renamed package manifests live?

        Line 24-25 - Unnecessary continuation, lines can be joined.

        Line 28-29 - Unnecessary continuation, lines can be joined.

components/ksh93/source-demo-ksh.p5m

        Why do you have these under components/ksh93 rather than
        components/meta-packages/history where all of the other
        obsoleted/renamed package manifests live?

        The copyright was unnecessarily changed - it should presumedly
        keep the year range.

        Line 24-25 - Unnecessary continuation, lines can be joined.

        Line 28-29 - Unnecessary continuation, lines can be joined.

components/ksh93/source-demo-ksh93.p5m

        Line 62-63 - Unnecessary continuation, lines can be joined.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to