On 06/14/12 08:22 PM, April Chin wrote:
Hi Edwin,
It looks like you changed everything I mentioned,
although you'll want to follow Danek's advice over mine,
since he is the IPS expert.
Thanks,
April
Thanks for the help - I've put all the suggestions together and respun
and tested the results. Danek has put his seal of approval on it too:
http://jurassic.us.oracle.com/~ebeasant/webrevs/7168548/
Thanks again,
Edwin
On 06/14/12 12:00 PM, Edwin Beasant wrote:
On 06/14/12 06:28 PM, April Chin wrote:
Hi Edwin,
Please see my comments below on your new webrev.
Thanks,
April
components/ksh93/developer-astdev.p5m:
- I'm not sure whether or not you need the trailing ".0" at the end.
Perhaps it's better to be consistent with the other build #s
and leave it off?
Done.
25 value=pkg:/developer/[email protected]
components/ksh93/developer-astdev93.p5m:
- This should be an "optional" dependency, instead of "require".
We only want to install the old astdev renamed pkg if astdev is
already
installed.
Aha, that makes sense, else you'd end up always having both packages?
Updated.
(and rest of the duplicates of this issue).
Respun webrev and respun builds in place.
Thanks again,
Edwin
On 06/14/12 08:52 AM, Edwin Beasant wrote:
I've made the changes suggested by April and Alan and respun the
webrev:
Original review request.
----
Can I please have a code review for:
7168548 <http://monaco.us.oracle.com/detail.jsf?cr=7168548>
package shell/ksh version number needs to conform.
Webrev:
http://jurassic.us.oracle.com/~ebeasant/webrevs/7168548/
Workspace:
x86: /net/shelf.uk.oracle.com/vol01/builds/ebeasant/userland/7168548
SPARC: /net/grinah.uk.oracle.com/builds/ebeasant/7168548
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
