Hi,

I've look a little hos to change the format, however it implies to modify source in maven core because of a check of <connection> value only allow 6 tokens.

Adding the cleartext password in the connection element as you suggest give 7 tokens and it's refused by the check code. Of course, a patch could modify this check...

I've started to look more precisely the code managing the CVS connection to modify it.

You suggest to look up the properties to get the password, did you mean those specified in prject.propertiers ? If so, how java code could read it ?

Carl


Eric Pugh wrote:


Hi guys...

I (trying to get logins to work) added in the code to use the cvslib instead
of cvs command line.  However, the cvslib doesn't support things like extssh
or ext, so if it fails, then it tries via the command line interface to
work.

Not sure about your stepping issue, I didn't have that problem..  Make sure
you have the latest and greatest..  also, look at the command line client in
the cvslib code, that is what i modeled CvsConnection on.  It does have a
pserver login method.  What we could do is add that logic into
CvsConnection.

Maybe change the format
<connection>scm:cvs:pserver:[EMAIL PROTECTED]:/usr/local/cvsroot:javaproject<
/connection> to something like this:
<connection>scm:cvs:pserver:carl:[EMAIL PROTECTED]:/usr/local/cvsroo
t:javaproject</connection>

so we could get the password?  Or look up the properties, that might be
better so it sin't in plaintext everywhere...

Patches are welcome..

Eric


-----Original Message-----
From: Carl [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 30, 2003 7:54 PM
To: Maven Users List
Subject: Re: password for CVS pserver ?




Sri Sankaran wrote:



<snip/>

b) Users must *know* to run the 'cvs login' command first.  I have
 tried to preGoal with a call to the ant:cvspass task.  Even
 though this task executes correctly and a .cvspass file is
 created, changelog merrily ignores it.

There is the problem. After a look in the soucre of chanlog

plugin, it


appears that it use org.netbeans.lib.cvsclient to manage

cvs connection.


All requiered methodes to log with a password seems to be present,
however I don't see how to modify the maven plugin to take

a password


parameter.


For some reason, when you step through the execution in a

debugger, the AbstractChangeLogGenerator's getEntries() method is getting invoked and not the overridden version in CvsChangeLogGenerator. Puzzling. Anyway I haven't fussed with it too much.

That's strange !


Do you know a way in java to access the "maven.cvs.password" value
define in project.properties ?


Don't know. What is it used for? Can you not just set it

on the command line?


It seems that many maven plugins use the contents of
project.properties,
so my idea was to add a new variable in this file, and modify the
changelog plugin to use it. But I don't know how to access
the variable.

Carl


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to