Eric Pugh wrote:

Okay,

I looked into the code again and rightnow, if you have .cvspass file then it
will log in using that.  However, what I am wondering is the order of
checks.  It seems to me that if you have a maven.changelog.password value
that you should use that.  Otherwise check for a .cvspass file and read it
in from there.

Now, I am wondering about the value.  My gut feeling is that if you are
using maven.changelog.password then you don't care that it is unencrypted.
And, apparently the .cvspass encryption is very weak, so security isn't
important.  So, if people want, I think I am going to tweak the plugin so
that if you have a maven.changelog.password it will use that.  Otherwise it
will check the .cvspass file.

That would be very nice and usefull. Thanks a lot to take time to do this.


Let us know,

Carl


Eric



-----Original Message-----
From: Eric Pugh [mailto:[EMAIL PROTECTED]
Sent: Friday, October 31, 2003 11:12 AM
To: 'Maven Users List'
Subject: RE: password for CVS pserver ?


Okay, I agree that maven.cvs.password is needlessly specific. Since we aren't trying to boil the waters with some sort of crazy sophisticated scheme, but just get the login to work, then we'll go with maven.changelog.password.

Your trick that you use, would you like to create the faq.fml
file in /xdocs
and submit it for changelog?  Neat idea...  Straightforward
concept once you
actually look at it!

Eric


-----Original Message-----
From: Jim Crossley [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 30, 2003 11:42 PM
To: Maven Users List
Subject: Re: password for CVS pserver ?


I'm not crazy about a CVS-specific property. I may be in the minority, but I've been using Maven a long time and never with CVS (mostly Perforce and StarTeam). Typically, I put the passwords in ~/build.properties, with owner-only rw privileges if I'm concerned. My repository connection then looks like this:

 <repository>
   <connection>

scm:starteam:${starteam.username}:[EMAIL PROTECTED]

   </connection>
 </repository>

So I guess I prefer maven.changelog.password if you want a standard,
but you really don't need one.

Jim


"Eric Pugh" <[EMAIL PROTECTED]> writes:



What do you think of a maven.cvs.password or

maven.changlog.password


property?

Eric


-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 30, 2003 10:06 PM
To: Maven Users List
Subject: RE: password for CVS pserver ?


Lets not allow passwords in project.xml. -- dIon Gillard, Multitask Consulting Blog: http://blogs.codehaus.org/people/dion/ Pub Key:http://blogs.codehaus.org/people/dion/public-key.asc


"Eric Pugh" <[EMAIL PROTECTED]> wrote on 31/10/2003 06:00:24 AM:



Hi guys...

I (trying to get logins to work) added in the code to use

the cvslib instead

of cvs command line. However, the cvslib doesn't support

things like extssh

or ext, so if it fails, then it tries via the command line

interface to


work.

Not sure about your stepping issue, I didn't have that

problem.. Make sure

you have the latest and greatest.. also, look at the

command line


client in

the cvslib code, that is what i modeled CvsConnection on.

It does have a

pserver login method.  What we could do is add that logic into
CvsConnection.

Maybe change the format


<connection>scm:cvs:pserver:[EMAIL PROTECTED]:/usr/local/cvsroo t:javaproject<

/connection> to something like this:


<connection>scm:cvs:pserver:carl:[EMAIL PROTECTED]:/us r/local/cvsroo

t:javaproject</connection>

so we could get the password? Or look up the properties,

that might be


better so it sin't in plaintext everywhere...

Patches are welcome..

Eric


-----Original Message-----
From: Carl [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 30, 2003 7:54 PM
To: Maven Users List
Subject: Re: password for CVS pserver ?




Sri Sankaran wrote:



<snip/>

b) Users must *know* to run the 'cvs login' command

first. I have


tried to preGoal with a call to the ant:cvspass

task. Even


though this task executes correctly and a

.cvspass file is


created, changelog merrily ignores it.

There is the problem. After a look in the soucre of chanlog

plugin, it


appears that it use org.netbeans.lib.cvsclient to manage

cvs connection.


All requiered methodes to log with a password seems

to be present,


however I don't see how to modify the maven plugin to take

a password


parameter.


For some reason, when you step through the execution in a

debugger, the AbstractChangeLogGenerator's getEntries() method is getting invoked and not the overridden version in CvsChangeLogGenerator. Puzzling. Anyway I haven't fussed with it too much.

That's strange !


Do you know a way in java to access the

"maven.cvs.password" value


define in project.properties ?


Don't know. What is it used for? Can you not just set it

on the command line?


It seems that many maven plugins use the contents of
project.properties,
so my idea was to add a new variable in this file, and

modify the


changelog plugin to use it. But I don't know how to access
the variable.

Carl




---------------------------------------------------------------------

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-- Jim Crossley http://crossleys.org/~jim 404.409.9085



---------------------------------------------------------------------


To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to