+1 from me - I think we have a handle on all the issues raised, but it would be better to make this release available and tidy them up into 0.18.1 in a week or two as Robbie suggested than to delay the entire release further.
On Fri, Oct 20, 2017 at 6:48 PM, Adel Boutros <[email protected]> wrote: > Fine for me :) > ________________________________ > From: Robbie Gemmell <[email protected]> > Sent: Friday, October 20, 2017 7:04:52 PM > To: [email protected] > Subject: Re: [VOTE] Release Apache Qpid Proton 0.18.0 > > I still feel the same after the latest reports/discussions, the > release will proceed unless something new comes up that convinces > otherwise. > > Many people have tested the RC with success, other components await > its release (e.g Dispatch 1.0.0 requires it), and there are existing > users who can't use the current 0.17.0 release on their systems > anymore and need something new (count me among them). > > I will do 0.18.1 within a week or two after more fixes and > improvemements to some of the issues noted are available and have had > time to settle. > > Robbie > > On 19 October 2017 at 18:52, Robbie Gemmell <[email protected]> > wrote: > > Thus far the things noted feel like reasons to do another release, > > rather than reasons to stop one thats long overdue. Based on what I've > > read so far there wont be a respin. > > > > It takes about the same amount of work [for me] to respin it as it > > does to just do another release. We dont do enough releases of Proton. > > I'll happily do another release soon, particularly once other issues > > and fixes have inevitably appeared. > > > > Robbie > > > > On 19 October 2017 at 18:36, Adel Boutros <[email protected]> wrote: > >> If the fix is quick, I prefer to have it natively in 0.18.0. Otherwise, > I will have to have a local patch to disable it and thus will have to build > a custom version of proton. > >> > >> Adel > >> ________________________________ > >> From: Alan Conway <[email protected]> > >> Sent: Thursday, October 19, 2017 7:19:50 PM > >> To: [email protected] > >> Subject: Re: [VOTE] Release Apache Qpid Proton 0.18.0 > >> > >> I can confirm the ipv6 problem, I've opened > >> https://issues.apache.org/jira/browse/PROTON-1639 and I'm working on > fixing > >> it in case of respin. > >> > >> On Thu, Oct 19, 2017 at 5:19 PM, Adel Boutros <[email protected]> > wrote: > >> > >>> I have a patch for the below failure (We have to re add -pthread to > >>> CMAKE_C_FLAGS). > >>> > >>> But now I have a new error in the tests related to IPv6. As my machine > >>> does not support IPv6, I have the -cproactor-tests failing > >>> > >>> test 21 > >>> Start 21: c-proactor-tests > >>> > >>> 21: Test command: /build-dir/proton/proton-c/ > src/tests/c-proactor-tests > >>> 21: Test timeout computed to be: 1500 > >>> 21: TEST: test_inactive(&t) > >>> 21: TEST: test_interrupt_timeout(&t) > >>> 21: TEST: test_errors(&t) > >>> 21: TEST: test_proton_1586(&t) > >>> 21: TEST: test_client_server(&t) > >>> 21: TEST: test_connection_wake(&t) > >>> 21: TEST: test_ipv4_ipv6(&t) > >>> 21: /qpid-proton-0.18.0-rc1/proton-c/src/tests/proactor.c:148: check > >>> failed: want PN_LISTENER_OPEN got PN_LISTENER_CLOSE > [test_ipv4_ipv6(&t)] > >>> 21: /qpid-proton-0.18.0-rc1/proton-c/src/tests/proactor.c:626: check > >>> failed: Unexpected condition - proton:io:Address family for hostname > not > >>> supported - connect to ::1:59983 [test_ipv4_ipv6(&t)] > >>> 21: /qpid-proton-0.18.0-rc1/proton-c/src/tests/proactor.c:627: check > >>> failed: Unexpected condition - proton:io:Connection refused - > disconnected > >>> :59983 [test_ipv4_ipv6(&t)] > >>> 21: /qpid-proton-0.18.0-rc1/proton-c/src/tests/proactor.c:628: check > >>> failed: Unexpected condition - proton:io:Address family for hostname > not > >>> supported - connect to ::1:43094 [test_ipv4_ipv6(&t)] > >>> 21: /qpid-proton-0.18.0-rc1/proton-c/src/tests/proactor.c:631: check > >>> failed: 'refused' not in 'Address family for hostname not supported - > >>> connect to ::1:58818' [test_ipv4_ipv6(&t)] > >>> 21: /qpid-proton-0.18.0-rc1/proton-c/src/tests/proactor.c:641: check > >>> failed: want PN_LISTENER_CLOSE got PN_PROACTOR_INACTIVE > [test_ipv4_ipv6(&t)] > >>> 21: FAIL: test_ipv4_ipv6(&t) (6 errors) > >>> 21: TEST: test_release_free(&t) > >>> 21: TEST: test_ssl(&t) > >>> 21: TEST: test_proactor_addr(&t) > >>> 21: TEST: test_parse_addr(&t) > >>> 21: TEST: test_netaddr(&t) > >>> 21: TEST: test_disconnect(&t) > >>> 21: TEST: test_abort(&t) > >>> 21: TEST: test_refuse(&t) > >>> 21: TEST: test_message_stream(&t) > >>> 21/25 Test #21: c-proactor-tests .................***Failed 0.10 sec > >>> > >>> Regards, > >>> Adel > >>> > >>> ________________________________ > >>> From: Adel Boutros <[email protected]> > >>> Sent: Thursday, October 19, 2017 5:53:47 PM > >>> To: [email protected] > >>> Subject: Re: [VOTE] Release Apache Qpid Proton 0.18.0 > >>> > >>> Hello again, > >>> > >>> > >>> I will have to vote -1 here. I am having issues with openssl on Linux > (I > >>> am using openssl 1.0.2h) > >>> > >>> > >>> [ 31%] Building C object proton-c/CMakeFiles/qpid- > proton.dir/src/reactor/ > >>> connection.c.o > >>> CMakeFiles/qpid-proton-core.dir/src/ssl/openssl.c.o: In function > >>> `ensure_initialized': > >>> /data/jenkins-slave/home/workspace/proton-acceptance/ > >>> proton-workspace/qpid-proton-0.18.0-rc1/proton-c/src/ssl/ > openssl.c:1505: > >>> undefined reference to `pthread_once' > >>> collect2: error: ld returned 1 exit status > >>> > >>> > >>> Regards, > >>> > >>> Adel > >>> > >>> ________________________________ > >>> From: Adel Boutros > >>> Sent: Thursday, October 19, 2017 5:42:01 PM > >>> To: [email protected] > >>> Subject: Re: [VOTE] Release Apache Qpid Proton 0.18.0 > >>> > >>> > >>> Hello, > >>> > >>> > >>> I am trying to build proton 0.18.0 but I am facing errors with > ruby-gem. > >>> Do you know how I can deactivate this target? > >>> > >>> > >>> [ 5%] Generating qpid_proton-0.18.0.gem > >>> /usr/bin/gem:8:in `require': no such file to load -- rubygems > (LoadError) > >>> from /usr/bin/gem:8 > >>> make[2]: *** [proton-c/bindings/ruby/qpid_proton-0.18.0.gem] Error 1 > >>> make[1]: *** [proton-c/bindings/ruby/CMakeFiles/ruby-gem.dir/all] > Error 2 > >>> > >>> > >>> Regards, > >>> > >>> Adel > >>> > >>> ________________________________ > >>> From: Jakub Scholz <[email protected]> > >>> Sent: Thursday, October 19, 2017 5:04:59 PM > >>> To: [email protected] > >>> Subject: Re: [VOTE] Release Apache Qpid Proton 0.18.0 > >>> > >>> +1. I build it from source code and used it with Qpid C++ broker > (master) > >>> and Qpid Dispatch (1.0.0 RC1) and run my tests against them. All seems > to > >>> work fine. > >>> > >>> On Wed, Oct 18, 2017 at 7:29 PM, Robbie Gemmell < > [email protected]> > >>> wrote: > >>> > >>> > Hi folks, > >>> > > >>> > I have put together a first spin for a Qpid Proton 0.18.0 release, > >>> > please test it and vote accordingly. > >>> > > >>> > The source archive can be grabbed from: > >>> > https://dist.apache.org/repos/dist/dev/qpid/proton/0.18.0-rc1/ > >>> > > >>> > The JIRAs currently assigned are: > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > >>> > projectId=12313720&version=12338903 > >>> > > >>> > It is tagged as 0.18.0-rc1. > >>> > > >>> > Regards, > >>> > Robbie > >>> > > >>> > ------------------------------------------------------------ > --------- > >>> > To unsubscribe, e-mail: [email protected] > >>> > For additional commands, e-mail: [email protected] > >>> > > >>> > > >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
