On Sat, Aug 07, 2021 at 06:32:34AM -0400, Joshua Kordani wrote: > Thank you for explaining the convention, it makes sense now that you > describe it like that. > > It was delightfully short work to hunt down with the rr debugger ;-) > > I'm having trouble testing it right now but I suspect it will work, I'll get > back to you on this. > > There is another caller of find_related_node, and again In the few minutes > of looking it wasn't obvious to me if that callsite also needed to correctly > track the first argument remaining NULL after the call? Line 5148.
The other caller should be fine because find_revision_for_suspected_deletion() will deal with related_repos_relpath being NULL. The problem in the case at hand is that we're passing related_repos_relpath to svn_path_url_add_component2() which cannot handle a NULL argument.
