Bob Hutchinson wrote:
> Well I decided to install a virgin copy of vegadns-0.9.9.1 and see what
> happened. The copy of vegadns that I use in production has lots of changes so
> I need to see what happens 'out-of-the-box'
>
> before running it, I put the following in to index.php, immediately after the
> other ini_set commands
>
> //ini_set('error_reporting', E_ALL ^ E_NOTICE);
> ini_set('error_reporting', E_ALL);
>
> The database was empty, so create_tables.php would run. This resulted in a
> nasty Notice:
>
> Notice: Use of undefined constant test - assumed 'test'
> in /home/hutch/www/html/vegadns-0.9.9.1/src/create_tables.php on line 43
>
> Warning: Cannot modify header information - headers already sent by (output
> started at /home/hutch/www/html/vegadns-0.9.9.1/src/create_tables.php:43)
> in /home/hutch/www/html/vegadns-0.9.9.1/index.php on line 108
>
> so I edited create_tables.php on line 43
> replaced md5(test) with md5('test')
>
> BTW I realise that I could have avoided this by setting
> ini_set('error_reporting', E_ALL ^ E_NOTICE);
> but then you don't find the bugs, that's how I set production boxes, not the
> development box I'm doing this on.
>
> cleared the database and ran again, closing the browser in between (just in
> case)
>
> much better, straight into the edit account page where I changed a few things
> and hit the edit button and it saved successfully, and left me logged in, I
> clicked around a bit, logged out and logged in again, no problem, it accepted
> the new password.
>
> This is the point that yours has been stumbling on, right?
> I'm using MySQL - 4.0.24
> You are using MySQL 5.0.18 right?
>
> does it support mysql_escape_string()
>
> see line 95 and on src/users.php
>
> do you see
>
> 'update accounts set First_Name=' and so on in your mysql log?
>
> The initial edit account page should have a hidden field for 'cid', it is set
> in index.php line 203 or thereabouts
>
> I'm just wondering if the refusal to save has to do with MySQL 5.x.xx ....
>
> I'm rather conservative about upgrading, this is just the kind of thing I
> dread, and the hords of angry customers...
>
> but it would be good to know in any event
Great work, Bob! I have not had time to address this myself yet, but it
looks like you've gotten to the heart of it. I'll test your findings
and try to get a 0.9.9.2 out with the fixes.
Regards,
Bil
