On Jan 10, 2008 10:10 PM, Edward Yakop <[EMAIL PROTECTED]> wrote: > On Jan 11, 2008 11:51 AM, Ryan Sonnek <[EMAIL PROTECTED]> wrote: > > if there are other improvements to be made, let me know! > > How about committing the [DraggableTargetBehavior] and its support for > multiple drag source type.
Not sure what you mean by "multiple drag source type". with my latest changes, you can have one draggable target that will accept *any* draggable (or sortable) object without using the DraggableTarget.accepts() methods. > The committed code has improved > JavascriptBuilder#formatJavascriptValue to support array, set and list > value. I didn't know about these changes. I'll try and take a look and see if I can reuse the code. Do you have unit tests? > Another reason why we prefer [DraggableTargetBehavior] instead of > [DraggableTarget], > when the drag target is an image (instead of the current test label), > I would not be able to "drop" to it. > This is because the <div>/<span> representing the [DraggableTarget] is > not being rendered by firefox browser. Can't you wrap your image in a div/span for the draggable target? I don't see this as a very strong usecase. Most usecases will have some kind of placeholder text instructing the user to drop objects on it. Does this work for you? <div wicket:id="draggableTarget"> Drop contents here! <img wicket:id="myImage" /> </div> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
