Hi, Thanks for your contribution!
The .zip that you attached is not really a patch :-/ It contains modified (I guess) complete files which I have to diff with the original ones to see what changes you have made... One thing that bothers me a lot is that (Inline)Enclosure functionality requires changes in o.a.w. Component and MarkupContainer. I really don't like Component.java to have logic/knowledge about (Inline)Enclosure. I agree that the bug is annoying but for now I find my workaround as the best solution - just add a dummy WebMarkupContainer in the hierarchy and the bug disappears. On Tue, Aug 21, 2012 at 9:13 AM, Veikko Törmänen <veikko.torma...@hotmail.com> wrote: > Hi! > > I have a fix/patch for two wicket bugs: > > https://issues.apache.org/jira/browse/WICKET-3947 > https://issues.apache.org/jira/browse/WICKET-3947 > > and > > https://issues.apache.org/jira/browse/WICKET-4700 > https://issues.apache.org/jira/browse/WICKET-4700 > > > This fix causes three of the junit tests to fail and I could use some help > on figuring them out. > > First two are in "org.apache.wicket.markup.html.border.ComponentBorderTest" > where both of tests cause error. > I don't understand what these tests do so I've had problems on locating the > problem. > > Third is in "org.apache.wicket.markup.html.internal.InlineEnclosureTest" > where testInlineEnclosurePage_1 causes error. > This test I understand but what I don't understand is why my patch causes > this error? > > If someone could take a look of this patch and could help me locate my > problem I would appreciate it. > > http://apache-wicket.1842946.n4.nabble.com/file/n4651386/Patch_for_WICKET-3947.zip > Patch_for_WICKET-3947.zip > > -Veikko > > > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386.html > Sent from the Users forum mailing list archive at Nabble.com. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
