First set of comments. As promised I will run the tests for you later tonight.
-Ivan P.S. Does it lint? http://codereview.chromium.org/39256/diff/1/6 File src/counters.cc (right): http://codereview.chromium.org/39256/diff/1/6#newcode61 Line 61: if (!histogram_) Two things here: - GetHistogram() sounds like it returns a value and it does and the next line then checks the histogram_ which is actually the return value of GetHistogram(). - Comparisons of pointers are with an explicit NULL. Makes for much easier reading since it does not imply that histogram_ is a boolean value. So maybe you should rewrite this to the following to avoid these issues: "if (GetHistogram() == NULL)" http://codereview.chromium.org/39256/diff/1/6#newcode70 Line 70: if (!histogram_) ditto http://codereview.chromium.org/39256 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
