http://codereview.chromium.org/39256/diff/1/6 File src/counters.cc (right):
http://codereview.chromium.org/39256/diff/1/6#newcode61 Line 61: if (!histogram_) On 2009/03/06 17:24:44, iposva wrote: > Two things here: > - GetHistogram() sounds like it returns a value and it does and the next line > then checks the histogram_ which is actually the return value of GetHistogram(). > - Comparisons of pointers are with an explicit NULL. Makes for much easier > reading since it does not imply that histogram_ is a boolean value. > So maybe you should rewrite this to the following to avoid these issues: > "if (GetHistogram() == NULL)" Done. http://codereview.chromium.org/39256/diff/1/6#newcode69 Line 69: GetHistogram(); On 2009/03/08 12:15:31, Søren Gjesse wrote: > Is this call needed in Stop as well as in Start? Done. http://codereview.chromium.org/39256/diff/1/6#newcode70 Line 70: if (!histogram_) On 2009/03/06 17:24:44, iposva wrote: > ditto Done. http://codereview.chromium.org/39256 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
