http://codereview.chromium.org/42020/diff/1/2 File include/v8.h (right):
http://codereview.chromium.org/42020/diff/1/2#newcode1916 Line 1916: static void SetAddHistogramSampleFunction(AddHistogramSampleCallback); On 2009/03/10 23:34:23, iposva wrote: > Please add comments documenting these two new V8 API calls. Done. http://codereview.chromium.org/42020/diff/1/6 File src/counters.cc (right): http://codereview.chromium.org/42020/diff/1/6#newcode76 Line 76: I was following the pattern used by the StatsCounters On 2009/03/10 23:34:23, iposva wrote: > These two functions could conceivably also be part of the header file. It is not > clear what make GetHistogram() more special compared to Start() or Stop(). http://codereview.chromium.org/42020/diff/1/7 File src/counters.h (right): http://codereview.chromium.org/42020/diff/1/7#newcode49 Line 49: static void SetAddHistogramSampleFunction(AddHistogramSampleCallback f) { On 2009/03/10 23:34:23, iposva wrote: > Small comment for the two new functions or extend the comment above to be more > generic. Done. http://codereview.chromium.org/42020/diff/1/7#newcode68 Line 68: static void *CreateHistogram(const char* name, On 2009/03/10 23:34:23, iposva wrote: > Comment missing similar to the one above, describing in what circumstances this > gets called. Done. http://codereview.chromium.org/42020/diff/1/7#newcode76 Line 76: static void AddHistogramSample(void* histogram, int sample) { On 2009/03/10 23:34:23, iposva wrote: > ditto Done. http://codereview.chromium.org/42020 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
