http://codereview.chromium.org/42020/diff/1/7 File src/counters.h (right):
http://codereview.chromium.org/42020/diff/1/7#newcode179 Line 179: // HistogramTimer t = { L"t:foo", NULL, false }; On 2009/03/10 23:34:23, iposva wrote: > Histograms are not created with a "t:" prefix as far as I can tell. Done. http://codereview.chromium.org/42020/diff/1/7#newcode196 Line 196: return histogram_ != NULL && start_time_ != 0 && stop_time_ == 0; On 2009/03/10 23:34:23, iposva wrote: > Usually we try to not rely on C precedence rules and format conditions in this > way: (a != b) && (b == c) Done. http://codereview.chromium.org/42020/diff/1011/1020 File src/v8-counters.cc (right): http://codereview.chromium.org/42020/diff/1011/1020#newcode35 Line 35: HistogramTimer Counters::name = { "" #caption, NULL, false, 0, 0 }; \ On 2009/03/11 16:42:24, Dean McNamee wrote: > You don't need the "" here do you? Done. http://codereview.chromium.org/42020 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
