Btw, one thing turned out during the test run... Now that the parser takes care of the sourceURL, we naturally don't have it before we have parsed the script.
So the sourceURL is not available in the "before compile" debug event.See the test fix. aandrey@, is this okay from the dev tools side? (yurys@ said previously that the dev tools side should be okay as long as cctest passes, and
it does now). https://codereview.chromium.org/316173002/diff/250001/src/vector.h File src/vector.h (right): https://codereview.chromium.org/316173002/diff/250001/src/vector.h#newcode103 src/vector.h:103: bool operator==(const Vector<T>& other) { On 2014/07/01 09:49:11, aandrey wrote:
bool operator==() const {
Done. https://codereview.chromium.org/316173002/diff/250001/src/vector.h#newcode104 src/vector.h:104: if (length_ != other.length_) return false; On 2014/07/01 09:49:11, aandrey wrote:
if (this == &other) return true; ?
I think this is even better: if (start_ == other.start_) return true; (Two vectors can point to the other same data. This check is inserted after the length check, so here we know that the lengths are equal.) https://codereview.chromium.org/316173002/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
