LGTM with nits.
https://codereview.chromium.org/316173002/diff/170001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/316173002/diff/170001/src/messages.js#newcode566
src/messages.js:566: $Array("source", "name", "source_url",
"source_mapping_url", "line_ends", "line_offset", "column_offset"),
80 columns...
https://codereview.chromium.org/316173002/diff/170001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/316173002/diff/170001/src/parser.cc#newcode3841
src/parser.cc:3841: void Parser::HandleMagicComments() {
Can we use a better name for this? I'm quite sure that in 2 weeks nobody
will have the slightest clue what "magic comments" are...
https://codereview.chromium.org/316173002/diff/170001/src/vector.h
File src/vector.h (right):
https://codereview.chromium.org/316173002/diff/170001/src/vector.h#newcode103
src/vector.h:103: bool IsEqualTo(Vector<T> other) {
Perhaps a const ref nicer? Furthermore, operator== is a better name, the
method is just lifting the underlying operator to the Vector after all.
https://codereview.chromium.org/316173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
