Thanks for review!
ulan@, since svenpanne@ reviewed everything, I'm not expecting you to
review too
(though, feel free to have a look if you want to). The same for vsevik@,
since
yurys@ has already reviewed.
I'm not going to land this until https://codereview.chromium.org/314603004/
lands, and I'm going to need to rebase on top of that (though, it should be
trivial).
https://codereview.chromium.org/316173002/diff/170001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/316173002/diff/170001/src/messages.js#newcode566
src/messages.js:566: $Array("source", "name", "source_url",
"source_mapping_url", "line_ends", "line_offset", "column_offset"),
On 2014/06/13 10:37:49, Sven Panne wrote:
80 columns...
Done (wut, why didn't the upload script whine??)
https://codereview.chromium.org/316173002/diff/170001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/316173002/diff/170001/src/parser.cc#newcode3841
src/parser.cc:3841: void Parser::HandleMagicComments() {
On 2014/06/13 10:37:49, Sven Panne wrote:
Can we use a better name for this? I'm quite sure that in 2 weeks
nobody will
have the slightest clue what "magic comments" are...
Renamed to HandleSourceURLComments. (Though, the term "magic comment" is
used on ContentSearchUtils in Inspector, that's why it was originally
named like that.)
https://codereview.chromium.org/316173002/diff/170001/src/vector.h
File src/vector.h (right):
https://codereview.chromium.org/316173002/diff/170001/src/vector.h#newcode103
src/vector.h:103: bool IsEqualTo(Vector<T> other) {
On 2014/06/13 10:37:49, Sven Panne wrote:
Perhaps a const ref nicer? Furthermore, operator== is a better name,
the method
is just lifting the underlying operator to the Vector after all.
Done.
https://codereview.chromium.org/316173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
