It is great th have all this working now!
http://codereview.chromium.org/171107/diff/1/3 File src/debug.cc (right): http://codereview.chromium.org/171107/diff/1/3#newcode1481 Line 1481: // Move one byte back to where the call instruction was placed. Comment out of sync with code. http://codereview.chromium.org/171107/diff/1/7 File src/x64/assembler-x64-inl.h (right): http://codereview.chromium.org/171107/diff/1/7#newcode233 Line 233: return pc_[11] != 0xCC; Please explain why non int3 instruction at pc + 11 is a call instruction :-). http://codereview.chromium.org/171107/diff/1/13 File src/x64/debug-x64.cc (right): http://codereview.chromium.org/171107/diff/1/13#newcode165 Line 165: // generated by X64CodeGenerator::ExitJSFrame. Please remove any reference to X64CodeGenerator::ExitJSFrame, as this function does not exist. Maybe refer to CodeGenerator::GenerateReturnSequence instead. It is the same issue with the ia32 version. http://codereview.chromium.org/171107/diff/1/15 File src/x64/virtual-frame-x64.cc (left): http://codereview.chromium.org/171107/diff/1/15#oldcode934 Line 934: Accidental edit? http://codereview.chromium.org/171107 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
