http://codereview.chromium.org/171107/diff/1/7 File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/171107/diff/1/7#newcode246 Line 246: Assembler::set_target_address_at(pc_ + Assembler::kReturnAddrPatchPrefixSize, I can't see a good and quick way to separate it. I have renamed the constants to kPatchReturnSequenceAddressOffset and kPatchReturnSequenceLength. We should think about a prettier solution. http://codereview.chromium.org/171107/diff/1/13 File src/x64/debug-x64.cc (right): http://codereview.chromium.org/171107/diff/1/13#newcode95 Line 95: // overwritten by the address of DebugBreakXXX. No, it was meant to refer to the DebugBreak<something> functions. Clearly it wasn't successful in doing that. http://codereview.chromium.org/171107/diff/1/14 File src/x64/macro-assembler-x64.cc (left): http://codereview.chromium.org/171107/diff/1/14#oldcode498 Line 498: WriteRecordedPositions(); It's correct in the sense that it matches what we do in ia32. We only record positions where we can set breakpoints, and we can only set breakpoints at stub calls and JSReturn sequences. In ia32 that means call(Handle<...>) and at function return. http://codereview.chromium.org/171107 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
