http://codereview.chromium.org/171107/diff/1/3 File src/debug.cc (right):
http://codereview.chromium.org/171107/diff/1/3#newcode1481 Line 1481: // Move one byte back to where the call instruction was placed. Fixed http://codereview.chromium.org/171107/diff/1/7 File src/x64/assembler-x64-inl.h (right): http://codereview.chromium.org/171107/diff/1/7#newcode233 Line 233: return pc_[11] != 0xCC; Has been elaborated. We only need to distinguish a call sequence from a JS return sequence, and only the latter has int3 at that position. http://codereview.chromium.org/171107/diff/1/13 File src/x64/debug-x64.cc (right): http://codereview.chromium.org/171107/diff/1/13#newcode165 Line 165: // generated by X64CodeGenerator::ExitJSFrame. Changed to refer to GenerateReturnSequence, and same in ia32. http://codereview.chromium.org/171107/diff/1/15 File src/x64/virtual-frame-x64.cc (left): http://codereview.chromium.org/171107/diff/1/15#oldcode934 Line 934: Indeed. Fixed. http://codereview.chromium.org/171107 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
