LGTM.
http://codereview.chromium.org/171107/diff/1/7 File src/x64/assembler-x64-inl.h (right): http://codereview.chromium.org/171107/diff/1/7#newcode246 Line 246: Assembler::set_target_address_at(pc_ + Assembler::kReturnAddrPatchPrefixSize, I really think this name is bad. Maybe there should be a friend Patcher class, and this could be Patcher::ReturnSequenceAddressOffset. Patcher::ReturnSequenceSize, and so on. http://codereview.chromium.org/171107/diff/1/13 File src/x64/debug-x64.cc (right): http://codereview.chromium.org/171107/diff/1/13#newcode95 Line 95: // overwritten by the address of DebugBreakXXX. Is there really a function called DebugBreakXXX? http://codereview.chromium.org/171107/diff/1/14 File src/x64/macro-assembler-x64.cc (left): http://codereview.chromium.org/171107/diff/1/14#oldcode498 Line 498: WriteRecordedPositions(); How can it be correct to remove this? http://codereview.chromium.org/171107 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
