https://codereview.chromium.org/424973004/diff/20001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/424973004/diff/20001/include/v8-profiler.h#newcode27
include/v8-profiler.h:27: int line;
On 2014/08/08 08:13:23, yurys wrote:
How about providing column as well which I already suggested before?
On minified
sources line number doesn't give enough information as the whole
script may be
formatted as one line.
The minified sources is useful to reduce the amount data that needs to
be transferred. It's difficult and inconvenient to use them for
profiling purpose. When developer identifies a position (column in alone
line representing his script) that impacts performance that next step is
modification of source code. I'm not sure that the minified sources give
a convenient way to understand a logic of the algorithm implemented in a
function, it's better to use original version of source file. That's why
I would suggest not to provide column in this patch. We always can do
that if the customers find it useful for profiling. What do you think?
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
