https://codereview.chromium.org/424973004/diff/40001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/424973004/diff/40001/src/profile-generator.cc#newcode226
src/profile-generator.cc:226: e->value = static_cast<char*>(e->value) +
1;
On 2014/08/11 12:18:15, alph wrote:
should be cast to uintptr_t
e->value is type of void* and used as a hit counter. To increment it by
1 void* should be casted to char* but not uintptr*. otherwise it will be
incremented by sizeof(int).
https://codereview.chromium.org/424973004/diff/40001/src/profile-generator.cc#newcode244
src/profile-generator.cc:244: entry->line =
reinterpret_cast<uintptr_t>(p->key);
On 2014/08/11 12:18:15, alph wrote:
I still bet it won't compile on x64 because of implicit 64->32 bits
conversion.
You have to write something like:
static_cast<usigned int>(reinterpret_cast<uintptr_t>(p->key));
Acknowledged.
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
