On 2014/08/11 06:19:52, yurys wrote:
On 2014/08/11 05:35:31, Denis Pravdin wrote:
>
https://codereview.chromium.org/424973004/diff/20001/include/v8-profiler.h
> File include/v8-profiler.h (right):
>
>
https://codereview.chromium.org/424973004/diff/20001/include/v8-profiler.h#newcode27
> include/v8-profiler.h:27: int line;
> On 2014/08/08 08:13:23, yurys wrote:
> > How about providing column as well which I already suggested before?
On
> minified
> > sources line number doesn't give enough information as the whole
script
may
be
> > formatted as one line.
>
> The minified sources is useful to reduce the amount data that needs to
be
> transferred. It's difficult and inconvenient to use them for profiling
purpose.
> When developer identifies a position (column in alone line representing
his
> script) that impacts performance that next step is modification of
source
code.
> I'm not sure that the minified sources give a convenient way to
understand a
> logic of the algorithm implemented in a function, it's better to use
original
> version of source file. That's why I would suggest not to provide
column in
this
> patch. We always can do that if the customers find it useful for
profiling.
What
> do you think?
We do have customers (inside Google) who profile sources produced by
closure
compiler. Also having a line+column we can use source maps to show
position in
the original source code while profiling compiled scripts. It won't be
possible
without column number. Copmplied scripts + source maps is quite common use
case,
that's why I suggested we should provide column from the very beginning
especially given that it shouldn't complicate the implementation. This
can be
implemented in a separate patch if you feel that it would be more
convenient
by
I think we need to support column information as well.
Thank you for letting me know about this usage case. Now I see that we need
to
support column information. Please do that in a separate patch.
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
