https://codereview.chromium.org/366153002/diff/900001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/366153002/diff/900001/test/cctest/test-api.cc#newcode23021
test/cctest/test-api.cc:23021: snprintf(copy, len + 1, "%s",
chunks_[index_]);
Argh, this discussion was confused.
So I originally had *strcpy* (not memcpy), but the whine was:
/media/ssdvol/v8-bleeding2/test/cctest/test-api.cc:23021: Almost
always, snprintf is better than strcpy [runtime/printf] [4]
(Curiously, it didn't suggest strncpy, so I thought snprintf is the
way.)
However, memcpy is the right function here, since I don't want to mess
with 0-termination.
https://codereview.chromium.org/366153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
