lgtm
https://codereview.chromium.org/366153002/diff/1160001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/366153002/diff/1160001/include/v8.h#newcode1096
include/v8.h:1096: class V8_EXPORT ExternalSourceStream {
nit. no need to V8 EXPORT - everything here is inline
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc#newcode12
src/background-parsing-task.cc:12: static const int
kBackgroundParserThreadStackSize = 64 * KB;
should this be FLAG_stack_size
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc#newcode74
src/background-parsing-task.cc:74: }
nit // namespace internal
also, empty line above this one
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc#newcode75
src/background-parsing-task.cc:75: } // namespace v8::internal
// namespace v8
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.h
File src/background-parsing-task.h (right):
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.h#newcode43
src/background-parsing-task.h:43: CompilationInfo* info;
nit. you could use SmartPointer<CompilationInfo> so you don't need to
delete all owned fields in the dtor (you won't need one at all)
https://codereview.chromium.org/366153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
