jochen: thanks for having a look!
yangguo: jochen said you'd be a good person for reviewing the UTF-8 handling
part, so, could you review scanner-character-streams.* ?
https://codereview.chromium.org/366153002/diff/1120001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/366153002/diff/1120001/include/v8.h#newcode1102
include/v8.h:1102: ExternalSourceStream(Encoding encoding) :
encoding(encoding) {}
On 2014/09/08 11:27:06, jochen wrote:
explicit
(This was removed)
https://codereview.chromium.org/366153002/diff/1120001/include/v8.h#newcode1116
include/v8.h:1116: virtual size_t GetMoreData(const uint8_t** src) = 0;
On 2014/09/08 11:27:06, jochen wrote:
that's kinda odd, a pure virtual interface shouldn't have a ctor
Done.
https://codereview.chromium.org/366153002/diff/1120001/include/v8.h#newcode1120
include/v8.h:1120: const Encoding encoding;
On 2014/09/08 11:27:06, jochen wrote:
or friends, or data members
it seems like all this class does is provide a single callback, no?
Done.
https://codereview.chromium.org/366153002/diff/1120001/include/v8.h#newcode1141
include/v8.h:1141: friend class internal::BackgroundParsingTask;
On 2014/09/08 11:27:06, jochen wrote:
can we do without friends here?
Added a private implementation and an accessor to it, so the friends are
gone.
https://codereview.chromium.org/366153002/diff/1120001/include/v8.h#newcode1147
include/v8.h:1147: ExternalSourceStream* source_stream;
On 2014/09/08 11:27:06, jochen wrote:
members should end in _
These are now in an internal struct, so not ending in _.
https://codereview.chromium.org/366153002/diff/1120001/src/background-parsing-task.h
File src/background-parsing-task.h (right):
https://codereview.chromium.org/366153002/diff/1120001/src/background-parsing-task.h#newcode21
src/background-parsing-task.h:21: class StreamingData {
On 2014/09/08 11:27:06, jochen wrote:
if it's just a container, this should be a struct
Done.
https://codereview.chromium.org/366153002/diff/1120001/src/background-parsing-task.h#newcode23
src/background-parsing-task.h:23: StreamingData(i::CompilationInfo* i,
uint32_t h, UnicodeCache* u, bool a)
On 2014/09/08 11:27:06, jochen wrote:
info, hash_seed, etc..
This code was deleted.
https://codereview.chromium.org/366153002/diff/1120001/src/background-parsing-task.h#newcode30
src/background-parsing-task.h:30: UnicodeCache* unicode_cache; //
Owned.
On 2014/09/08 11:27:06, jochen wrote:
how can this be owned, if the data is copied around?
Prevented copying (which was non-prevented by omission).
https://codereview.chromium.org/366153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
