On 2014/09/04 13:45:00, marja wrote:
svenpanne, jochen, ptal.

Okay, now this is ready for review for realz. There are even tests.

Please review as follows:
svenpanne: v8.h
jochen: everything


Re: previous discussion, I changed const char* to const uint8_t* in the API, since that seems to be the data type for "bunch of raw bytes" on the V8 side
(Blink uses const char* but this seems to be the V8 way - see for example
CachedData).

(And changing the subject of the e-mail thread now too just for general
feeling-better-about-this-CL purposes.)

https://codereview.chromium.org/366153002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to