(thanks for having a look; now only commenting on the encoding names, will
fix
the other naming comment later)
https://codereview.chromium.org/366153002/diff/1180001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/366153002/diff/1180001/include/v8.h#newcode1129
include/v8.h:1129: enum Encoding { ONE_BYTE, TWO_BYTE, UTF8 };
On 2014/09/10 13:48:58, Yang wrote:
On 2014/09/10 13:39:28, rossberg wrote:
> Not specific to this CL, but I wonder if we shouldn't eventually
change these
> names to ASCII and UCS2, for more clarity...
Rather Latin1 instead of ASCII.
Yep, not ASCII, since it actually is Latin1, not ascii. However, the V8
term for it seems to be "one byte" - it's used everywhere.
(ASCII was leftover from the days where it was actually ASCII - yangguo@
is just fixing it right now.)
Why "UCS2" though? Isn't UTF-16 a much more well known term? Do you mean
it's actually not UTF-16?
https://codereview.chromium.org/366153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
