On 2014/09/09 11:46:30, marja wrote:
Thanks for review!
https://codereview.chromium.org/366153002/diff/1160001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/366153002/diff/1160001/include/v8.h#newcode1096
include/v8.h:1096: class V8_EXPORT ExternalSourceStream {
On 2014/09/09 08:06:20, jochen wrote:
> nit. no need to V8 EXPORT - everything here is inline
Done.
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc#newcode12
src/background-parsing-task.cc:12: static const int
kBackgroundParserThreadStackSize = 64 * KB;
On 2014/09/09 08:06:20, jochen wrote:
> should this be FLAG_stack_size
Done.
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc#newcode74
src/background-parsing-task.cc:74: }
On 2014/09/09 08:06:20, jochen wrote:
> nit // namespace internal
>
> also, empty line above this one
git cl format removes the empty line if I put one there.
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.cc#newcode74
src/background-parsing-task.cc:74: }
On 2014/09/09 08:06:20, jochen wrote:
> nit // namespace internal
>
> also, empty line above this one
Counter nit: this seems pretty customary:
$ git grep "// namespace v8::internal" | wc -l
691
$ git grep "// namespace internal" | wc -l
96
So not changing this; also, there's no risk of misunderstanding it.
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.h
File src/background-parsing-task.h (right):
https://codereview.chromium.org/366153002/diff/1160001/src/background-parsing-task.h#newcode43
src/background-parsing-task.h:43: CompilationInfo* info;
On 2014/09/09 08:06:20, jochen wrote:
> nit. you could use SmartPointer<CompilationInfo> so you don't need to
delete
all
> owned fields in the dtor (you won't need one at all)
Done.
lgtm.
https://codereview.chromium.org/366153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
