Thanks for the look, I've re-arranged code a bit to address the style
issues,
and added some extra test cases.
https://codereview.chromium.org/663683006/diff/600001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/663683006/diff/600001/src/parser.cc#newcode5150
src/parser.cc:5150: if (raw_chars[from_index + 1] == '\n') {
On 2014/11/14 12:28:07, rossberg wrote:
Perhaps add a comment explaining that it is actually safe to access
index+1 here
without checking against the length first.
Hmm, I'm not sure this is guaranteed to be safe, actually. Adding a
check.
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
