https://codereview.chromium.org/663683006/diff/520001/test/mjsunit/es6/templates.js
File test/mjsunit/es6/templates.js (right):
https://codereview.chromium.org/663683006/diff/520001/test/mjsunit/es6/templates.js#newcode134
test/mjsunit/es6/templates.js:134: (function(s) { calls++;
assertEquals("foo", s[0]); })`foo`;
On 2014/11/12 16:19:10, arv wrote:
I didn't imply that you need to add this to all your functions. I only
suggested
that you replace the boolean one above.
Yeah, but I think it doesn't hurt for the other cases, since there are
slight differences in the parsed pattern, it's good to be thorough. It's
a bit redundant, but that's great in tests, so long as it's not
problematic
https://codereview.chromium.org/663683006/diff/520001/test/mjsunit/es6/templates.js#newcode290
test/mjsunit/es6/templates.js:290: assertTrue("raw" in cs);
On 2014/11/12 16:19:10, arv wrote:
Generally, prefer hasOwnProperty or getOwnPropertyDescription since in
can imply
that the property is available in the prototype chain.
Acknowledged.
https://codereview.chromium.org/663683006/diff/520001/test/mjsunit/es6/templates.js#newcode293
test/mjsunit/es6/templates.js:293: cs[1] = true;
On 2014/11/12 16:19:10, arv wrote:
A better way to test for read only is to assert that the property
descriptor has
writable == false.
Changed it to assert values of property descriptor properties instead
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
