On 2014/11/13 15:04:03, marja wrote:
Btw, I would've wanted to have a look at your latest edits, but the latest
patch
sets seem to be a rebase plus your edits, which makes the "delta between
patch
sets" feature not useful for this. :( In the future, pls upload rebases as
separate patch sets (marked as "rebased" or such) so this is easier.
Whoops.
The changes are very minor: ScanTemplateSpan will never return
Token::IlLEGAL,
but either Token::EOS or one of the two TEMPLATE_* tokens. This way it's
possible for the preparser to report a nicer error (unterminated template
literal, unterminated template expression), rather than "Illegal token".
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.