LGTM
https://codereview.chromium.org/663683006/diff/540001/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/663683006/diff/540001/test/mjsunit/harmony/templates.js#newcode297
test/mjsunit/harmony/templates.js:297: assertTrue(cs.raw instanceof
Array);
Similar issue with instanceof as in. In test you are better of being
more precise:
assertEquals(Array.prototype. Object.getPrototypeOf(cs.raw));
assertTrue(Array.isArray(cs.raw));
You do not really have to change this but next time you write tests keep
it in mind.
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
