https://codereview.chromium.org/749633002/diff/80001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/749633002/diff/80001/src/compiler/ast-graph-builder.cc#newcode2016
src/compiler/ast-graph-builder.cc:2016: if
(variable->IsSignallingAssignmentToConst(op, strict_mode())) {
On 2014/11/25 15:23:36, rossberg wrote:
I'm not sure I like this factorisation, since it breaks the symmetry
with the
other cases below and thereby makes the code less readable. It also
duplicates
some of the cases analysis. Better factor it out into the two relevant
cases
below.
Michi, what do you think?
Acknowledged. I would slightly prefer writing down the cases explicitly
as Andreas suggested, but I don't care enough be the deciding factor
here. I am fine either way (sorry for being evasive).
https://codereview.chromium.org/749633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
