Thanks. :) LGTM up to the comments below.
https://codereview.chromium.org/749633002/diff/140001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/749633002/diff/140001/src/compiler/ast-graph-builder.cc#newcode2041
src/compiler/ast-graph-builder.cc:2041: } else if (mode == CONST && op
!= Token::INIT_CONST) {
Why not merge this case with the above?
https://codereview.chromium.org/749633002/diff/140001/src/compiler/ast-graph-builder.cc#newcode2075
src/compiler/ast-graph-builder.cc:2075: } else if (mode == CONST && op
!= Token::INIT_CONST) {
Same here.
https://codereview.chromium.org/749633002/diff/140001/src/variables.h
File src/variables.h (right):
https://codereview.chromium.org/749633002/diff/140001/src/variables.h#newcode140
src/variables.h:140: bool IsSignallingAssignmentToConst(Token::Value op,
Can you also move this to full-codegen.h? This is compilation logic for
assignments, and should not pollute the variable interface.
https://codereview.chromium.org/749633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
