On 2014/11/26 08:52:33, Dmitry Lomov (chromium) wrote:
https://codereview.chromium.org/749633002/diff/140001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/749633002/diff/140001/src/compiler/ast-graph-builder.cc#newcode2041
src/compiler/ast-graph-builder.cc:2041: } else if (mode == CONST && op !=
Token::INIT_CONST) {
On 2014/11/26 08:31:46, rossberg wrote:
> Why not merge this case with the above?
And extract the condition into IsNonInitializingAssignementToConst
because it
is
so unwieldy? Riiight.
No, leave the condition in clear text, not obfuscate it with a spurious
abstraction. ;)
There is way too much ado around a bunch of conditionals
Agreed. Sorry about that, but I'm allergic to this kind of thing, because
that's
what slowly turns clean and readable code into Crankshaft over time.
https://codereview.chromium.org/749633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
