Comments addressed, landing
https://codereview.chromium.org/749633002/diff/140001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/749633002/diff/140001/src/compiler/ast-graph-builder.cc#newcode2041
src/compiler/ast-graph-builder.cc:2041: } else if (mode == CONST && op
!= Token::INIT_CONST) {
On 2014/11/26 08:52:32, Dmitry Lomov (chromium) wrote:
On 2014/11/26 08:31:46, rossberg wrote:
> Why not merge this case with the above?
And extract the condition into IsNonInitializingAssignementToConst
because it is
so unwieldy? Riiight.
There is way too much ado around a bunch of conditionals
Actually, I realized that we also decided that non-initializing
assignments to (non-legacy) const should throw in all modes, so these
cases are not unifiable. Fixed here and in full codegen
https://codereview.chromium.org/749633002/diff/140001/src/variables.h
File src/variables.h (right):
https://codereview.chromium.org/749633002/diff/140001/src/variables.h#newcode140
src/variables.h:140: bool IsSignallingAssignmentToConst(Token::Value op,
On 2014/11/26 08:31:46, rossberg wrote:
Can you also move this to full-codegen.h? This is compilation logic
for
assignments, and should not pollute the variable interface.
Done.
https://codereview.chromium.org/749633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
