https://codereview.chromium.org/771483002/diff/20001/test/mjsunit/harmony/array-concat.js
File test/mjsunit/harmony/array-concat.js (right):
https://codereview.chromium.org/771483002/diff/20001/test/mjsunit/harmony/array-concat.js#newcode10
test/mjsunit/harmony/array-concat.js:10: assertEquals(1,
Array.prototype.concat.length);
On 2014/12/10 10:58:21, Dmitry Lomov (chromium) wrote:
Add a test that validates that concat works correctly on on objects
in fast
mode, including Smis and doubles
I'm not sure how to create a non-array object which would take the
FAST_SMI_ELEMENTS or FAST_DOUBLE_ELEMENTS paths --- I have only managed
to get it taking the FAST_ELEMENTS and FAST_HOLEY_ELEMENTS paths, and
never FAST_DOUBLE_ELEMENTS.
https://codereview.chromium.org/771483002/diff/20001/test/mjsunit/harmony/array-concat.js#newcode185
test/mjsunit/harmony/array-concat.js:185: /*
On 2014/12/10 10:58:20, Dmitry Lomov (chromium) wrote:
Stray comments
Yeah, I had these commented out because they caused hangs when
implemented in JS --- these were removed in patch set 3
https://codereview.chromium.org/771483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
