We forgot once case. Marking "not lgtm" to prevent accidental landing.
https://codereview.chromium.org/771483002/diff/100001/src/runtime/runtime-array.cc
File src/runtime/runtime-array.cc (right):
https://codereview.chromium.org/771483002/diff/100001/src/runtime/runtime-array.cc#newcode467
src/runtime/runtime-array.cc:467:
Oops, I forgot one more case - please remove default clause in the
switch, line 609, and make sure to handle SLOPPY_ARGUMENTS_ELEMENTS
https://codereview.chromium.org/771483002/diff/100001/test/mjsunit/harmony/array-concat.js
File test/mjsunit/harmony/array-concat.js (right):
https://codereview.chromium.org/771483002/diff/100001/test/mjsunit/harmony/array-concat.js#newcode5
test/mjsunit/harmony/array-concat.js:5: // Flags: --harmony-arrays
--harmony-classes
Add a test for sloppy arguments (install isConcatSpreadable on them and
pass to concat)
https://codereview.chromium.org/771483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
