Sorry for raising false alarms on FAST_SMI_ELEMENTS and friends, these are
only
applicable for JSArrays
https://codereview.chromium.org/771483002/diff/20001/src/runtime/runtime-array.cc
File src/runtime/runtime-array.cc (right):
https://codereview.chromium.org/771483002/diff/20001/src/runtime/runtime-array.cc#newcode463
src/runtime/runtime-array.cc:463: Runtime::GetObjectProperty(isolate,
receiver, key), false);
On 2014/12/10 10:58:20, Dmitry Lomov (chromium) wrote:
Here you use whatever length the incoming object gives you, so it does
not have
"the amazing Array length behavior". This means that the assumptions
in
remainder of this method do not hold, in particular DCHECKs in lines
477 and
511.
Ah ok sorry I jumped the gun here, FAST_(SMI|DOUBLE)_(HOLEY_)ELEMENTS
are indeed JSArray only
https://codereview.chromium.org/771483002/diff/20001/test/mjsunit/harmony/array-concat.js
File test/mjsunit/harmony/array-concat.js (right):
https://codereview.chromium.org/771483002/diff/20001/test/mjsunit/harmony/array-concat.js#newcode185
test/mjsunit/harmony/array-concat.js:185: /*
On 2014/12/10 13:25:33, caitp wrote:
On 2014/12/10 10:58:20, Dmitry Lomov (chromium) wrote:
> Stray comments
Yeah, I had these commented out because they caused hangs when
implemented in JS
--- these were removed in patch set 3
Oops sorry.
https://codereview.chromium.org/771483002/diff/60001/test/mjsunit/harmony/array-concat.js
File test/mjsunit/harmony/array-concat.js (right):
https://codereview.chromium.org/771483002/diff/60001/test/mjsunit/harmony/array-concat.js#newcode9
test/mjsunit/harmony/array-concat.js:9: (function testArrayConcatArity()
{
Please add a test that sets isConcatSpreadable on a typed array (small
and large)
https://codereview.chromium.org/771483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
