On 2014/12/10 15:29:20, caitp wrote:
https://codereview.chromium.org/771483002/diff/60001/test/mjsunit/harmony/array-concat.js
File test/mjsunit/harmony/array-concat.js (right):
https://codereview.chromium.org/771483002/diff/60001/test/mjsunit/harmony/array-concat.js#newcode9
test/mjsunit/harmony/array-concat.js:9: (function testArrayConcatArity() {
On 2014/12/10 14:41:59, Dmitry Lomov (chromium) wrote:
> Please add a test that sets isConcatSpreadable on a typed array (small
and
> large)
Acknowledged --- but reading the draft, I am not seeing
TypedArrays/ArrayBuffers/DataViews as concat-spreadable, unless I'm
missing
something. So I think these tests are just asserting that the typed
arrays are
NOT spread, is that right?
I meant, just set isConcatSpreadable manually on an instance of typed array
and
pass it to concat.
The goal of the test is to exercise IterateElements (that you have changed
to
accept more than just JSArray) on all possible ElementKinds.
https://codereview.chromium.org/771483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
