https://codereview.chromium.org/771483002/diff/170001/src/runtime/runtime-array.cc
File src/runtime/runtime-array.cc (right):
https://codereview.chromium.org/771483002/diff/170001/src/runtime/runtime-array.cc#newcode583
src/runtime/runtime-array.cc:583:
IterateExternalArrayElements<FixedInt8Array, int8_t>(
On 2014/12/11 15:11:29, Dmitry Lomov (chromium) wrote:
Please rename IterateExternalArrayElements into
IterateTypedArrayElements (this
no longer only iterates externals)
Done.
https://codereview.chromium.org/771483002/diff/170001/test/mjsunit/harmony/array-concat.js
File test/mjsunit/harmony/array-concat.js (right):
https://codereview.chromium.org/771483002/diff/170001/test/mjsunit/harmony/array-concat.js#newcode122
test/mjsunit/harmony/array-concat.js:122: var ta = new type(items);
On 2014/12/11 15:11:29, Dmitry Lomov (chromium) wrote:
The reason why you are not hitting UINT8_ELEMENTS and friends, only
EXTERNAL_UINT8_ELEMENTS and friends, is because only new
TypedArray(length) call
allocates in-heap typed arrays.
Remove `items` and initialize `ta` directly - then you should hit the
cases you
have added.
In order to use Fixed<Type>Array, the length needs to be less than
FLAG_typed_array_max_size_in_heap with a null JSArrayBuffer, far as I
can tell --- so I think I'm only hitting this from the "small" array
case, but it works
https://codereview.chromium.org/771483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
